-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish and update version history v6.9.3 #527
base: master
Are you sure you want to change the base?
Conversation
VersionHistory.md
Outdated
@@ -1,5 +1,9 @@ | |||
# Changelog | |||
|
|||
## 6.9.3 | |||
|
|||
- Update popperjs/core dependecy version to 2.11.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think "dependency" is misspelled here 😅
package.json
Outdated
@@ -51,7 +51,7 @@ | |||
"styled-components": "^4 || ^5" | |||
}, | |||
"dependencies": { | |||
"@popperjs/core": "^2.4.0", | |||
"@popperjs/core": "^2.11.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Did you pull styled-ui
before making your edit here and creating this PR? This change has already been made on the main branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not pull from styled-ui
before making this PR, I didn't realize I needed to since these changes were already made. I am not sure why this is a part of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should rebase this atop the latest from origin/master
578df8d
to
c2a42e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review to get this out of my notifications.
No description provided.